@a6644890

Hi Thanks for using my plugin!!! Yep, I fly an autogyro.

@ofir-goldstein The picker shows interpolated values, if you zoom to level 8 or more, it stays constant.

@marekd

Thanks!! Please use our code.

@jacobsjo

1. Disabling the older module is tricky, it consists of a bunch of listeners, which will all have to be deactivated. Certainly possible. Just deleting the module from W does not work.

2. Yep, good idea to send the ident, included it. The onOtherPluginOpened function is called on rqstOpen, thus before the new plugin does anything. You can then keep the svg when another plugin opens, or check the name of the plugin and decide whether to remove it.

3. I dynamically load stylesheets for my other external modules. You can start with a standard style sheet.

I moved the modules to a new repo: https://github.com/rittels/windy-plugins-modules.

Ideally the pluginCoordinator functionality should be included in the plugins-plugin.

Thanks @jacobsjo version control added.

Hi @jacobsjo

Agree with everything you said.

1. Unfortunately the users browser caches the dependency, so you have to specify the version. You can force reload with ?"+Math.random(), but this needs to done from inside windy. (Also will take longer to load for a dependency which should hopefully be stable.)

(Ideally it should be inside the windy-plugin, maybe one-day.)

2. Exactly the point of the pluginCoordinator. It sets the lastOpened property to false for your plugin and if W.plugins["windy-plugin-sun-position"].onOtherPluginOpened() exists, will call it when another plugin opens. So for example you can say:

this.onOtherPluginOpened = () => {  /*instead of this.onopen*/
   isOpen = false;
   d3.select(".picker").select("svg").remove()
}

3. Unfortunately the module only executes once it is opened. So if you click "open", it will work, but if you click "load" (for the 1st time), it still hangs. 😟

4. yeah, I do lots of hacky things, so if onOtherPuginOpened is called, you can clean it up if you want.

5. Yep, u are right, will make new repo for the modules.

Thanks for your answer.

@ivo, @marekd, @mhaberler, @vicb, @jakubvrana, @johnckealy, @jacobsjo, @okocedion.

Hi everyone.

There have been few problems with the current plugin loader:

• If you click the open button when the plugin has already loaded, it tries to reload the plugin and then hangs, since the modules have already been defined.
• If you open another plugin, the listeners and dom elements remain active, which becomes messy. You can use onclose, but this is triggered when the plugin element is closed, not when a different plugin is opened. Also, generally, you want to be able to close the pane, but keep the plugin active.

I created a module to help fix these problems:

It loads as an external dependency and installs as a module in the W object (W.windy-plugin-module-pluginCoordinator). It loads just once, through the 1st plugin that contains it. It is included in all my plugins. You can include it in your plugins by adding it to the config.js file's dependencies array. It is executed immediately when loaded, and does not need to be imported in the plugin. I published it on npm: https://www.npmjs.com/package/windyplugin-module-plugin-coordinator. See the readme file for more detail.

Ideally this functionality can be included in the plugins-plugin.

I have created a number of other modules, commonly used in my plugins, also published on npm (pickerTools, airspaces, infobox and rplannerWrapper). I will still comment on them and place them on github.

Let me know what you think.

@peterevans

Done!

Thanks for the feedback. You're welcome to make suggestions.

I am busy trying to coordinate interaction between the plugins.

Do not load and then open. Just open directly. Let me know if that works.

The open button loads the plugin and opens. If u click load and then click open it tries to reload modules and breaks.

Sorry, Im busy updating it. Should be working soon.

Short plugin:

windy-plugin-no-labels

Removes the labels layer. Works on satellite. Borders still there.